analysis of new dumpdev service use case outcomes

Before r256348:
+ '# Set dumpdev to "AUTO" to enable crash dumps, "NO" to disable' is always appended to rc.conf
+ User is always presented the dialog "Would you like to enable crash dumps?  If you start having problems with the system it can help the FreeBSD developers debug the problem.  But the crash dumps can take up a lot of disk space in /var."

Case 1 (still before r256348):
- User selects "Yes" to abovementioned dialog prompt
+ dumpdev="AUTO" is appended to rc.conf

Case 2 (still before r256348):
- User selects "No" to abovementioned dialog prompt
+ dumpdev="NO" is appended to rc.conf

So we have two out-comes:

Case 1 rc.conf:
# Set dumpdev to "AUTO" to enable crash dumps, "NO" to disable
dumpdev="AUTO"

Case 2 rc.conf:
# Set dumpdev to "AUTO" to enable crash dumps, "NO" to disable
dumpdev="NO"

The intent or r256348 is to stop asking the user if they want to enable dumbdev and instead integrate it into the services menu (enabled by default). This reduces the amount of keystrokes required to get to the very end "Reboot" option.

It seems fair to think that code should be changed so that when the dumpdev service is disabled, the same cases occur. However, this is how the current code works:

After r259276 in HEAD, or after r259621 in stable/10, or after r259652 in releng/10.0, incorporated in time for release/10.0:
+ The dumpdev option is now integrated into the services menu.

Case 1:
- User leaves the dumpdev checklist enabled
+ '# Set dumpdev to "AUTO" to enable crash dumps, "NO" 'to disable' is appended to rc.conf
+ dumpdev="AUTO" is appended to rc.conf

Case 2:
- User unchecks the dumpdev option in the services menu
+ dumpdev="NO" is appended to rc.conf

So again, we still have only two outcomes, but they are now:

Case 1 rc.conf:
# Set dumpdev to "AUTO" to enable crash dumps, "NO" 'to disable
dumpdev="AUTO"

Case 2 rc.conf:
dumpdev="NO"

The proper patch to make the Case 2 outcome match the pre-r256348 Case 2 outcome would be as follows:

Index: services
===================================================================
--- services    (revision 259618)
+++ services    (working copy)
@@ -63,5 +63,7 @@ for daemon in $DAEMONS; do
 done

 if [ ! "$havedump" ]; then
+       echo '# Set dumpdev to "AUTO" to enable crash dumps, "NO"' \
+            'to disable' >> $BSDINSTALL_TMPETC/rc.conf.services
        echo dumpdev=\"NO\" >> $BSDINSTALL_TMPETC/rc.conf.services
 fi

Note how the patch prefers to keep the comment next to the setting.
EDIT: See completed/committed patch...
http://svnweb.freebsd.org/base?view=revision&revision=260866

A note to the person that brought this to my attention... in this
particular case, it wasn't enough to say "the comment isn't showing
up" because in between r256348 and r259276 (an elapsed time of 2
months) there was an unintended bug wherein the outcomes were as
described:

Case 1 rc.conf (after r256348 but before r259276):
dumpdev="AUTO"

Case 2 rc.conf (after r256348 but before r259276):
dumpdev="NO"

So for just over 2 months, we weren't getting the comment for either outcome. I believe the above patch will restore what it is that you request, which is to have both cases produce the pre-r256348 outcomes).
--
Devin