Advertisement
phpface

Untitled

Feb 15th, 2018
228
0
Never
Not a member of Pastebin yet? Sign Up, it unlocks many cool features!
text 3.58 KB | None | 0 0
  1. 1. Mobile styling needs attention/improvement in some areas. Please check/test your pages carefully and resolve all issues.
  2. example: https://envato.d.pr/exAnfV
  3.  
  4. 2. There are a few inconsistent spacing/padding as well as alignment issues throughout the design. Please go through your files and weed out these basic design issues.
  5.  
  6. 3. Please resolve all warning and required messages output by the Theme Check plugin, https://wordpress.org/plugins/theme-check/ - Anything you include within your theme must be up to the same standards as the theme itself. (You can ignore the "Zip file found." message reported)
  7. https://envato.d.pr/8nTJMy
  8.  
  9. 4. Default styling needs attention - https://envato.d.pr/t8oD4E
  10.  
  11. 5. Default logo/sitename does not display - https://envato.d.pr/Dveih7
  12.  
  13. 6. Themes execute the presentation and styling of content while plugins handle content creation and functionality. Anything users will lose upon switching themes is classified as plugin territory. Here are some common examples:
  14. - Analytics
  15. - SEO options
  16. - Forms
  17. - Non-design related meta boxes
  18. - Resource caching
  19. - Dashboard widgets
  20. - Custom Post Types
  21. - Custom Taxonomies
  22. - Shortcodes
  23. - Social media “like”, “follow” and “share” buttons
  24. Anything that falls into plugin territory must be added via a custom plugin.
  25. You may use TGM Plugin Activation or equivalent to prompt the user to install the plugin on theme activation, but it cannot be activated without user action.
  26.  
  27. example(s) : https://envato.d.pr/NCcWDn
  28.  
  29. 7. Please make sure all default Theme Unit Test content is formatted properly.
  30. example(s) and there are more:
  31. https://envato.d.pr/zcvi7
  32. How to test the blog/posts layout/functionality - Import the Theme Unit Test [http://codex.wordpress.org/Theme_Unit_Test] file and make sure that:
  33.  
  34. - All default content is formatted properly.
  35. - Posts display correctly, with no apparent visual problems or errors.
  36. - Posts display in correct order.
  37. - Page navigation displays and works correctly.
  38. - As "sticky posts" are a core feature, the theme should style and display them appropriately.
  39. - Lack of body text should not adversely impact the layout.
  40. - Theme must incorporate both the "Tag" and the "Category" taxonomies in some manner.
  41. - Floats are cleared properly for floated element (thumbnail image) at the end of the post content.
  42.  
  43. Reference link: https://wpthemetestdata.wordpress.com/
  44.  
  45. 8. Data Validation issues have been found in your theme. All dynamic data must be correctly escaped for the context where it is rendered. - All dynamic data must be escaped with esc_attr() before rendered in an html attribute. - Whenever you are rendering a url to the screen its value must be passed through esc_url() first. - If dynamic data is rendered inside an attribute that triggers a JavaScript event, it must be escaped with esc_js().
  46.  
  47. Please make sure you read these articles:
  48. https://make.wordpress.org/themes/tags/writing-secure-themes/ http://codex.wordpress.org/Data_Validation http://developer.wordpress.com/themes/escaping/ http://code.tutsplus.com/articles/data-sanitization-and-validation-with-wordpress--wp-25536 https://vip.wordpress.com/documentation/best-practices/security/validating-sanitizing-escaping/
  49.  
  50. 9. You should avoid and not to hardcode custom body_class(). Main reason for this is being able to remove the class when needed i.e. child themes. What you can do - https://gist.github.com/kailoon/d4d22c9204909dff21eb
  51. ref: http://themeshaper.com/2014/11/20/mastering-the-post_class-function/ https://codex.wordpress.org/Function_Reference/body_class#Add_Classes_By_Filters
Advertisement
Add Comment
Please, Sign In to add comment
Advertisement