Advertisement
Not a member of Pastebin yet?
Sign Up,
it unlocks many cool features!
- Review
- Positives:
- - Data binding usage
- - Coroutines usage
- - LiveData usage
- - Retrofit usage
- - The application has an architecture, Api, Retository, ViewModel.
- - The source code is buildable and the application is working
- - The app's appearance matches the design plan (More or less)
- - Caching, no network calls after screen rotation
- Negatives:
- - RelativeLayout is used instead of ConstraintLayout. Not a huge thing, but RelativeLayout is not very common these days
- - "Not null assertion operator" used a lot of times - code smell
- - No proper DI. ViewModel dependencies are instantiated in the Fragments
- - No loading
- - No proper error handling
- - Deprecated method calls, for example: getParcelable, onBackPressed
- - Code formatting
- - No unit tests
- - If I rotate the screen on the details page, then the UI becomes a bit disorganised
- Overall, it's not bad, the application works, the design is almost correct, and it implements a large portion of the libraries we use.
Advertisement
Add Comment
Please, Sign In to add comment
Advertisement